From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Date: Tue, 10 Mar 2026 11:39:06 +1000 Message-ID: In-Reply-To: <20260310012458.169272-1-damon.ding@rock-chips.com> References: <20260310012458.169272-1-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Apply drm_bridge_connector and panel_bridge helper for the Analogix DP driver Author: Damon Ding Patches: 14 Reviewed: 2026-03-10T11:39:06.394629 --- This is a well-structured v10 series that modernizes the Analogix DP bridge driver by migrating from a private `drm_connector` to the `drm_bridge_connector` and `panel_bridge` helpers. The series has been through extensive iteration and has accumulated substantial review/test tags (Reviewed-by from Dmitry Baryshkov and Luca Ceresoli, Tested-by from Marek Szyprowski and Heiko Stuebner). The decomposition into 18 patches is logical - first adding the `next_bridge` plat_data field, then moving the legacy bridge for multi-platform use, cleaning up unused fields and callbacks, migrating to bridge_connector, and finally consolidating the panel/bridge parsing into `analogix_dp_finish_probe()`. **Key concerns:** 1. A bug in exynos_dp.c where `next_bridge` gets clobbered after being set from the display-mode bridge fallback. 2. The `analogix_dp_start_crc`/`stop_crc` bridge type check is fragile. 3. The `analogix_dp_unbind()` still calls `analogix_dp_bridge_disable()` and `drm_panel_unprepare()` which may conflict with the bridge_connector framework's teardown sequence. **Note:** The mbox file is truncated and only includes patches 1-13 of 18. Patches 14-18 (applying `analogix_dp_finish_probe()` on Rockchip/Exynos, attaching next bridge in analogix_dp_bridge_attach, removing bridge disabling/panel unpreparing in unbind, and applying panel_bridge helper) are not available for full review. The review below covers the 13 available patches plus observations from the final applied state. --- Generated by Claude Code Patch Reviewer