From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gem-dma: Support dedicated DMA device for allocation
Date: Wed, 11 Mar 2026 13:48:35 +1000 [thread overview]
Message-ID: <review-overall-20260310032012.2542334-1-wenst@chromium.org> (raw)
In-Reply-To: <20260310032012.2542334-1-wenst@chromium.org>
Overall Series Review
Subject: drm/gem-dma: Support dedicated DMA device for allocation
Author: Chen-Yu Tsai <wenst@chromium.org>
Patches: 5
Reviewed: 2026-03-11T13:48:35.189516
---
This is a well-structured 4-patch series that extends the existing `drm_dev_dma_dev()` / `drm_dev_set_dma_dev()` infrastructure to the GEM DMA helpers for allocation and mmap operations. The motivation is clear: several embedded SoC display drivers (MediaTek, Allwinner, Exynos, Rockchip) have reinvented this wheel with custom GEM callbacks, and this series aims to consolidate that into the core helpers. The approach is sound and the code is straightforward. The MediaTek conversion is a satisfying deletion of ~250 lines of custom code. The sun4i conversion properly fixes a misuse of `of_dma_configure()` that triggers warnings with IOMMUs.
Overall the series looks good. I have a few observations below, mostly minor.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 3:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 3:20 [PATCH 0/4] drm/gem-dma: Support dedicated DMA device for allocation Chen-Yu Tsai
2026-03-10 3:20 ` [PATCH 1/4] drm/prime: Limit scatter list size with dedicated DMA device Chen-Yu Tsai
2026-03-11 3:48 ` Claude review: " Claude Code Review Bot
2026-03-10 3:20 ` [PATCH 2/4] drm/gem-dma: Support dedicated DMA device for allocation and mapping Chen-Yu Tsai
2026-03-11 3:48 ` Claude review: " Claude Code Review Bot
2026-03-10 3:20 ` [PATCH 3/4] drm/mediatek: Set dedicated DMA device and drop custom GEM callbacks Chen-Yu Tsai
2026-03-11 3:48 ` Claude review: " Claude Code Review Bot
2026-03-10 3:20 ` [PATCH 4/4] drm/sun4i: Use backend/mixer as dedicated DMA device Chen-Yu Tsai
2026-03-11 3:48 ` Claude review: " Claude Code Review Bot
2026-03-11 3:48 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-10 3:25 [PATCH RESEND 0/4] drm/gem-dma: Support dedicated DMA device for allocation Chen-Yu Tsai
2026-03-11 3:45 ` Claude review: " Claude Code Review Bot
2026-03-11 9:49 [PATCH v2 0/4] " Chen-Yu Tsai
2026-03-11 21:08 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260310032012.2542334-1-wenst@chromium.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox