From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gem-dma: Support dedicated DMA device for allocation Date: Wed, 11 Mar 2026 13:48:35 +1000 Message-ID: In-Reply-To: <20260310032012.2542334-1-wenst@chromium.org> References: <20260310032012.2542334-1-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/gem-dma: Support dedicated DMA device for allocation Author: Chen-Yu Tsai Patches: 5 Reviewed: 2026-03-11T13:48:35.189516 --- This is a well-structured 4-patch series that extends the existing `drm_dev_dma_dev()` / `drm_dev_set_dma_dev()` infrastructure to the GEM DMA helpers for allocation and mmap operations. The motivation is clear: several embedded SoC display drivers (MediaTek, Allwinner, Exynos, Rockchip) have reinvented this wheel with custom GEM callbacks, and this series aims to consolidate that into the core helpers. The approach is sound and the code is straightforward. The MediaTek conversion is a satisfying deletion of ~250 lines of custom code. The sun4i conversion properly fixes a misuse of `of_dma_configure()` that triggers warnings with IOMMUs. Overall the series looks good. I have a few observations below, mostly minor. --- Generated by Claude Code Patch Reviewer