From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/gem-dma: Support dedicated DMA device for allocation Date: Wed, 11 Mar 2026 13:45:57 +1000 Message-ID: In-Reply-To: <20260310032511.2545500-1-wenst@chromium.org> References: <20260310032511.2545500-1-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/gem-dma: Support dedicated DMA device for allocation Author: Chen-Yu Tsai Patches: 9 Reviewed: 2026-03-11T13:45:57.938628 --- This is a well-structured and clearly motivated series by Chen-Yu Tsai that extends the existing `drm_dev_set_dma_dev()` / `drm_dev_dma_dev()` infrastructure to cover GEM DMA allocation and mapping, then converts two drivers (MediaTek and sun4i) to use it instead of ad-hoc workarounds. The approach is sound: consolidating "dedicated DMA device" handling in the core helpers avoids code duplication across drivers and eliminates the problematic `of_dma_configure()` hack in sun4i. The series is logically ordered, well-explained, and the net diffstat is very positive (deleting ~250 lines of custom code). The core changes in patches 1-2 are safe for existing users since no current driver both uses GEM DMA helpers and calls `drm_dev_set_dma_dev()`. A few minor observations below, but overall this looks good and ready to merge through drm-misc-next. --- Generated by Claude Code Patch Reviewer