From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Enable ADSP and CDSP for Glymur SoC Date: Wed, 11 Mar 2026 13:43:34 +1000 Message-ID: In-Reply-To: <20260310033617.3108675-1-sibi.sankar@oss.qualcomm.com> References: <20260310033617.3108675-1-sibi.sankar@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Enable ADSP and CDSP for Glymur SoC Author: Sibi Sankar Patches: 9 Reviewed: 2026-03-11T13:43:34.927214 --- This is a straightforward V4 series adding ADSP and CDSP support for the Qualcomm Glymur SoC. The series is well-structured: dt-bindings first (patches 1-3), then SoC DTSI definitions (patch 4), then board enablement (patch 5). The Glymur remoteproc nodes are declared fully compatible with Kaanapali (for fastrpc) and sm8550 (for PAS), which is consistent with the existing pattern for sm8750. The DTS node structure closely follows sm8750/sm8550 precedents. Patches 4 and 5 have Reviewed-by tags from Abel Vesa and Konrad Dybcio. Overall this looks clean and correct with a few minor observations below. --- Generated by Claude Code Patch Reviewer