From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova: rename drivers to use kebab-case convention
Date: Wed, 11 Mar 2026 13:37:58 +1000 [thread overview]
Message-ID: <review-overall-20260310062443.2763230-1-yphbchou0911@gmail.com> (raw)
In-Reply-To: <20260310062443.2763230-1-yphbchou0911@gmail.com>
Overall Series Review
Subject: gpu: nova: rename drivers to use kebab-case convention
Author: Cheng-Yang Chou <yphbchou0911@gmail.com>
Patches: 3
Reviewed: 2026-03-11T13:37:58.845294
---
This is a single-patch series that renames the Nova GPU driver module names from CamelCase (`"NovaCore"`, `"Nova"`) to kebab-case (`"nova-core"`, `"nova-drm"`) to follow kernel naming conventions before these names become UAPI. The motivation is sound — the linked issue (Rust-for-Linux/linux#1228) tracks this naming convention concern, and it's better to fix this before UAPI exposure via `driver_override`.
The patch is small, focused, and the three changes are internally consistent. However, there are two issues worth discussing.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-11 3:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 6:24 [PATCH] gpu: nova: rename drivers to use kebab-case convention Cheng-Yang Chou
2026-03-10 20:41 ` Timur Tabi
2026-03-11 1:34 ` John Hubbard
2026-03-11 3:37 ` Claude Code Review Bot [this message]
2026-03-11 3:37 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260310062443.2763230-1-yphbchou0911@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox