From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: video: fbdev: omapfb: Add missing error check for clk_get() Date: Wed, 11 Mar 2026 13:28:19 +1000 Message-ID: In-Reply-To: <20260310085625.2648545-1-nichen@iscas.ac.cn> References: <20260310085625.2648545-1-nichen@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: video: fbdev: omapfb: Add missing error check for clk_get() Author: Chen Ni Patches: 2 Reviewed: 2026-03-11T13:28:19.231251 --- This is a single-patch series adding a missing error check for `clk_get()` = in the OMAP HWA742 fbdev driver. The bug is real =E2=80=94 `clk_get()` can = return an error pointer, and the current code blindly passes it to `clk_get= _rate()`, `clk_prepare_enable()`, etc., which would dereference the error p= ointer and crash the kernel. The fix is straightforward and mostly correct,= though it has one issue with the error path cleanup. --- Generated by Claude Code Patch Reviewer