From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/colorop: Keep colorop state consistent across atomic commits
Date: Wed, 11 Mar 2026 13:23:06 +1000 [thread overview]
Message-ID: <review-overall-20260310113238.3495981-1-chaitanya.kumar.borah@intel.com> (raw)
In-Reply-To: <20260310113238.3495981-1-chaitanya.kumar.borah@intel.com>
Overall Series Review
Subject: drm/colorop: Keep colorop state consistent across atomic commits
Author: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Patches: 3
Reviewed: 2026-03-11T13:23:06.659608
---
This is a well-motivated 2-patch fix series addressing colorop state inconsistency during internal/driver-initiated atomic commits. The cover letter clearly explains the problem: when Intel's PSR2/CRC workaround triggers an internal commit via `drm_atomic_add_affected_planes()`, colorop states are either missing from the transaction or, when included, have their `bypass` property incorrectly reset to `true` during state duplication. The two patches work together to fix both sides of the bug.
The changes are small, targeted, and appropriate for stable backport. The fix is correct in my assessment, though patch 2 has a minor concern worth discussing.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-11 3:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 11:32 [PATCH v2 0/2] drm/colorop: Keep colorop state consistent across atomic commits Chaitanya Kumar Borah
2026-03-10 11:32 ` [PATCH v2 1/2] drm/colorop: Preserve bypass value in duplicate_state() Chaitanya Kumar Borah
2026-03-11 3:23 ` Claude review: " Claude Code Review Bot
2026-03-10 11:32 ` [PATCH v2 2/2] drm/atomic: Add affected colorops with affected planes Chaitanya Kumar Borah
2026-03-11 3:23 ` Claude review: " Claude Code Review Bot
2026-03-11 3:23 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260310113238.3495981-1-chaitanya.kumar.borah@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox