From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/colorop: Keep colorop state consistent across atomic commits Date: Wed, 11 Mar 2026 13:23:06 +1000 Message-ID: In-Reply-To: <20260310113238.3495981-1-chaitanya.kumar.borah@intel.com> References: <20260310113238.3495981-1-chaitanya.kumar.borah@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/colorop: Keep colorop state consistent across atomic commits Author: Chaitanya Kumar Borah Patches: 3 Reviewed: 2026-03-11T13:23:06.659608 --- This is a well-motivated 2-patch fix series addressing colorop state inconsistency during internal/driver-initiated atomic commits. The cover letter clearly explains the problem: when Intel's PSR2/CRC workaround triggers an internal commit via `drm_atomic_add_affected_planes()`, colorop states are either missing from the transaction or, when included, have their `bypass` property incorrectly reset to `true` during state duplication. The two patches work together to fix both sides of the bug. The changes are small, targeted, and appropriate for stable backport. The fix is correct in my assessment, though patch 2 has a minor concern worth discussing. --- Generated by Claude Code Patch Reviewer