From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Date: Wed, 11 Mar 2026 13:12:59 +1000 Message-ID: In-Reply-To: <20260310144914.7525-6-jonathan.cavitt@intel.com> References: <20260310144914.7525-6-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/xe/xe_vm: Implement xe_vm_get_property_ioctl Author: Jonathan Cavitt Patches: 5 Reviewed: 2026-03-11T13:12:59.406327 --- This v37 series adds a `DRM_IOCTL_XE_VM_GET_PROPERTY` ioctl that allows use= rspace to query failed page faults recorded against a VM. The series is wel= l-structured into four logical patches: a bugfix for read-only VMA enforcem= ent, a uAPI definition, internal fault storage infrastructure, and the ioct= l implementation. At v37 it has clearly received extensive review, but ther= e are still several issues worth addressing =E2=80=94 most notably a bug in= the read-only VMA check in patch 1, a TOCTOU race in the ioctl helper, and= some uAPI naming/structure concerns. --- Generated by Claude Code Patch Reviewer