From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/hdmi: Simplify the code Date: Thu, 12 Mar 2026 06:45:26 +1000 Message-ID: In-Reply-To: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> References: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm/hdmi: Simplify the code Author: Krzysztof Kozlowski Patches: 8 Reviewed: 2026-03-12T06:45:26.014914 --- This is a straightforward 7-patch cleanup series for the MSM HDMI driver from Krzysztof Kozlowski. All patches are purely cosmetic/style improvements with no functional changes. The series is well-organized with each patch addressing a distinct cleanup concern: using `dev_of_node()`, removing duplicate error messages, introducing a local `dev` variable, switching to kernel-preferred `u32` types, removing redundant `int` from `unsigned long int`, and introducing `hdmi_clear_bits()`/`hdmi_update_bits()` helpers. The series is clean and ready to merge. One minor nit on the cover letter and one subtle improvement worth noting are called out below. --- Generated by Claude Code Patch Reviewer