public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/dsi: Restore widebus calculation for CMDMode panels
Date: Fri, 13 Mar 2026 14:40:21 +1000	[thread overview]
Message-ID: <review-overall-20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org> (raw)
In-Reply-To: <20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org>

Overall Series Review

Subject: drm/msm/dsi: Restore widebus calculation for CMDMode panels
Author: Marijn Suijten <marijn.suijten@somainline.org>
Patches: 4
Reviewed: 2026-03-13T14:40:21.566414

---

This is a single-patch fix for a regression introduced by commit ac47870fd795 ("drm/msm/dsi: fix hdisplay calculation when programming dsi registers"). That commit removed the command-mode widebus path that set `bits_per_pclk = 48`, incorrectly claiming CMD mode doesn't use this code path. The result is that all DSI DSC command-mode panels on SM8350+ (with widebus support) broke — the `hdisplay` calculation became wrong because `mipi_dsi_pixel_format_to_bpp()` returns 24 for RGB888, identical to the non-widebus case, so widebus effectively did nothing.

The fix is logically correct and restores the original behavior for CMD mode while preserving the video-mode change from ac47870fd795.

**Note:** The current drm-next tree (line 1030 of `dsi_host.c`) already has a different refactoring of this area that uses `bytes_per_pclk` (3/6) instead of `bits_per_pclk` (24/48), and already includes the `!(msm_host->mode_flags & MIPI_DSI_MODE_VIDEO)` guard. This means the regression may have already been fixed differently on drm-next, and this patch targets a tree where ac47870fd795 exists but that subsequent refactoring hasn't landed. The maintainers should verify which tree this needs to go into (likely a stable backport target).

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-13  4:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 22:31 [PATCH] drm/msm/dsi: Restore widebus calculation for CMDMode panels Marijn Suijten
2026-03-12  5:10 ` Pengyu Luo
2026-03-12 13:18 ` AngeloGioacchino Del Regno
2026-03-12 23:08   ` Marijn Suijten
2026-03-13  4:40 ` Claude review: " Claude Code Review Bot
2026-03-13  4:40 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260311-dsi-dsc-regresses-again-v1-1-6a422141eeea@somainline.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox