From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: simplify pvr_fw_trace_seq_data Date: Wed, 11 Mar 2026 12:56:11 +1000 Message-ID: In-Reply-To: <20260311004014.32240-1-rosenp@gmail.com> References: <20260311004014.32240-1-rosenp@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/imagination: simplify pvr_fw_trace_seq_data Author: Rosen Penev Patches: 1 Reviewed: 2026-03-11T12:56:11.528185 --- This is a single-patch series that converts `pvr_fw_trace_seq_data` from using a separate heap allocation for its `buffer` member to using a C flexible array member (FAM). This is a straightforward and correct cleanup that: 1. Reduces the number of allocations from two to one 2. Removes the associated error-handling path and `kfree` call 3. Uses the kernel's `kzalloc_flex` helper correctly The patch is clean and correct. It follows an established kernel pattern for converting pointer+allocation pairs to flexible array members. --- Generated by Claude Code Patch Reviewer