public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sysfb: Fix efidrm error handling and memory type mismatch
Date: Thu, 12 Mar 2026 07:16:10 +1000	[thread overview]
Message-ID: <review-overall-20260311064652.2903449-1-nichen@iscas.ac.cn> (raw)
In-Reply-To: <20260311064652.2903449-1-nichen@iscas.ac.cn>

Overall Series Review

Subject: drm/sysfb: Fix efidrm error handling and memory type mismatch
Author: Chen Ni <nichen@iscas.ac.cn>
Patches: 2
Reviewed: 2026-03-12T07:16:10.625324

---

This is a single-patch series fixing two real bugs in `efidrm_device_create()`:

1. **Incorrect error checking for `devm_memremap()`**: The original code checks `if (!screen_base)`, but `devm_memremap()` returns `ERR_PTR()` on failure, not `NULL`. So the error path was never triggered for the WT/WB cases.

2. **`iosys_map` type mismatch**: `devm_memremap()` returns `void *` (system memory), but the original code unconditionally calls `iosys_map_set_vaddr_iomem()` which sets `is_iomem = true`. For WT/WB memory, `iosys_map_set_vaddr()` (which sets `is_iomem = false`) should be used instead.

Both are legitimate bugs. The fix is correct in approach and addresses both issues properly.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-11 21:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  6:46 [PATCH v2] drm/sysfb: Fix efidrm error handling and memory type mismatch Chen Ni
2026-03-11  7:44 ` Thomas Zimmermann
2026-03-11 21:16 ` Claude Code Review Bot [this message]
2026-03-11 21:16 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260311064652.2903449-1-nichen@iscas.ac.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox