From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sysfb: Fix efidrm error handling and memory type mismatch Date: Thu, 12 Mar 2026 07:16:10 +1000 Message-ID: In-Reply-To: <20260311064652.2903449-1-nichen@iscas.ac.cn> References: <20260311064652.2903449-1-nichen@iscas.ac.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/sysfb: Fix efidrm error handling and memory type mismatch Author: Chen Ni Patches: 2 Reviewed: 2026-03-12T07:16:10.625324 --- This is a single-patch series fixing two real bugs in `efidrm_device_create()`: 1. **Incorrect error checking for `devm_memremap()`**: The original code checks `if (!screen_base)`, but `devm_memremap()` returns `ERR_PTR()` on failure, not `NULL`. So the error path was never triggered for the WT/WB cases. 2. **`iosys_map` type mismatch**: `devm_memremap()` returns `void *` (system memory), but the original code unconditionally calls `iosys_map_set_vaddr_iomem()` which sets `is_iomem = true`. For WT/WB memory, `iosys_map_set_vaddr()` (which sets `is_iomem = false`) should be used instead. Both are legitimate bugs. The fix is correct in approach and addresses both issues properly. --- Generated by Claude Code Patch Reviewer