Claude review: drm/mipi-dbi: Replace simple-display helpers with regular atomic helpers

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/mipi-dbi: Replace simple-display helpers with regular atomic helpers
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 17
Reviewed: 2026-03-12T07:03:36.620218

---

This is a well-structured 16-patch series by Thomas Zimmermann that converts all mipi-dbi-based DRM drivers from the `drm_simple_display_pipe` abstraction to regular atomic modesetting helpers (explicit plane, CRTC, encoder, connector). The goal is to deprecate the simple-kms helpers entirely, since their continued use and documentation attracts new drivers to a deprecated API.

The approach is sound:
1. Fix commit ordering so planes update after CRTC enable (patch 1)
2. Factor out device init from pipeline setup (patch 2)
3. Provide new atomic helper callbacks and initializer macros (patch 3)
4. Convert each driver mechanically (patches 4-14)
5. Remove dead simple-pipe code from mipi-dbi (patch 15)
6. Deprecate simple-kms entirely (patch 16)

**Key concerns:**
- **Bug:** Uninitialized `new_crtc_state` in `drm_mipi_dbi_plane_helper_atomic_check()` (patch 3) — this will use stack garbage when the plane has no CRTC.
- **Multiple typos** in patch 16's deprecation text.
- The series is compile-tested only; hardware testing is explicitly requested.

The driver conversions (patches 4-14) are mechanical and consistent. The series is ready after fixing the bug and typos noted below.

---

---
Generated by Claude Code Patch Reviewer