From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon: fix __user annotation in radeon_info_ioctl()
Date: Thu, 12 Mar 2026 06:51:40 +1000 [thread overview]
Message-ID: <review-overall-20260311142138.530006-1-ben.dooks@codethink.co.uk> (raw)
In-Reply-To: <20260311142138.530006-1-ben.dooks@codethink.co.uk>
Overall Series Review
Subject: drm/radeon: fix __user annotation in radeon_info_ioctl()
Author: Ben Dooks <ben.dooks@codethink.co.uk>
Patches: 1
Reviewed: 2026-03-12T06:51:40.410492
---
This is a single, straightforward patch that adds the missing `__user` annotation to the `value_ptr` variable in `radeon_info_ioctl()`. The fix is correct and complete — `value_ptr` is derived from a user-space address (`info->value`) and is exclusively used with `copy_from_user()` and `copy_to_user()`, so it should indeed carry the `__user` annotation. This is a textbook sparse warning fix with no functional change.
**Verdict: Patch looks good. No issues found.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-11 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 14:21 [PATCH] drm/radeon: fix __user annotation in radeon_info_ioctl() Ben Dooks
2026-03-11 20:51 ` Claude review: " Claude Code Review Bot
2026-03-11 20:51 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260311142138.530006-1-ben.dooks@codethink.co.uk \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox