From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/syncobj: Enforce strict checking of timeline syncobj struct Date: Thu, 12 Mar 2026 06:50:35 +1000 Message-ID: In-Reply-To: <20260311144524.3046352-2-dev@lankhorst.se> References: <20260311144524.3046352-2-dev@lankhorst.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/syncobj: Enforce strict checking of timeline syncobj struct Author: Maarten Lankhorst Patches: 1 Reviewed: 2026-03-12T06:50:35.480324 --- This is a single patch that tightens input validation for the DRM syncobj `handle_to_fd` and `fd_to_handle` ioctls. The motivation is sound: userspace was able to set `args->point` without the `TIMELINE` flag, or set the `TIMELINE` flag without the `EXPORT_SYNC_FILE`/`IMPORT_SYNC_FILE` flag, leading to silent misbehavior. The fix is clean and well-structured. However, there is one potential **userspace ABI regression concern** that deserves discussion. --- Generated by Claude Code Patch Reviewer