From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Support sensors for column utilization Date: Thu, 12 Mar 2026 06:48:17 +1000 Message-ID: In-Reply-To: <20260311171842.473453-1-lizhi.hou@amd.com> References: <20260311171842.473453-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: Support sensors for column utilization Author: Lizhi Hou Patches: 3 Reviewed: 2026-03-12T06:48:17.277058 --- This is a single-patch series (V2) adding column utilization sensor support to the `accel/amdxdna` driver. It extends the existing `aie2_get_sensors()` function to return up to 8 column utilization sensors alongside the existing power sensor, using NPU busy metrics from the AMD PMF driver. The approach is reasonable and the patch is relatively small, but there are a few issues worth addressing around buffer validation, the `!CONFIG_AMD_PMF` stub, and the hard-coded array size. --- Generated by Claude Code Patch Reviewer