public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Fix gamma 2.2 colorop TFs
Date: Fri, 13 Mar 2026 14:43:47 +1000	[thread overview]
Message-ID: <review-overall-20260311211837.2482799-1-alex.hung@amd.com> (raw)
In-Reply-To: <20260311211837.2482799-1-alex.hung@amd.com>

Overall Series Review

Subject: drm/amd/display: Fix gamma 2.2 colorop TFs
Author: Alex Hung <alex.hung@amd.com>
Patches: 2
Reviewed: 2026-03-13T14:43:47.091244

---

This is a single-patch fix that corrects the gamma 2.2 transfer function assignments in the AMD display colorop code. The fix is straightforward, well-motivated by a bug report, and already has a `Tested-by` tag from the KDE compositor developer who reported the issue.

The change is **correct**. The existing code had `GAMMA22` and `GAMMA22_INV` swapped relative to what degamma/shaper/blend operations require. Looking at the pattern of the other transfer functions in the same lists:

- **degamma** and **blend** use linearizing (EOTF) curves: `SRGB_EOTF`, `PQ_125_EOTF`, `BT2020_INV_OETF`
- **shaper** uses de-linearizing (inverse EOTF / OETF) curves: `SRGB_INV_EOTF`, `PQ_125_INV_EOTF`, `BT2020_OETF`

Per the header documentation (`drm_colorop.h:116-117`), `GAMMA22` "applies a power curve with gamma value of 2.2" — i.e., it linearizes gamma-encoded values (an EOTF-like operation). Its inverse `GAMMA22_INV` de-linearizes. So `GAMMA22` belongs with degamma/blend, and `GAMMA22_INV` belongs with shaper — exactly what this patch does.

No concerns with the patch. It should be safe to apply.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-13  4:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11 21:18 [PATCH] drm/amd/display: Fix gamma 2.2 colorop TFs Alex Hung
2026-03-12 22:35 ` Melissa Wen
2026-03-13  4:43 ` Claude Code Review Bot [this message]
2026-03-13  4:43 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260311211837.2482799-1-alex.hung@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox