From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] staging: fbtft: fb_ra8875: replace udelay() with usleep_range() Date: Fri, 13 Mar 2026 14:46:08 +1000 Message-ID: In-Reply-To: <2026031151-fragrant-geometry-4b3f@gregkh> References: <2026031151-fragrant-geometry-4b3f@gregkh> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] staging: fbtft: fb_ra8875: replace udelay() with uslee= p_range() Author: Greg KH Patches: 3 Reviewed: 2026-03-13T14:46:08.864398 --- This is a single, straightforward cleanup patch replacing `udelay(100)` wit= h `usleep_range(100, 200)` in a staging driver. The change is correct and f= ollows the standard kernel coding guideline: for delays =E2=89=A5 10 =C2=B5= s in non-atomic context, `usleep_range()` is preferred over `udelay()` to a= void busy-waiting. Since the function performs SPI writes (which can sleep)= , this code is clearly in a sleepable context, making the conversion safe. The patch is simple, well-scoped, and the commit message adequately explain= s the rationale. **Verdict: Looks good (minor nit below).** --- Generated by Claude Code Patch Reviewer