From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu/discovery: Add braces to case statements in amdgpu_discovery_table_check()
Date: Fri, 13 Mar 2026 13:44:39 +1000 [thread overview]
Message-ID: <review-overall-20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org> (raw)
In-Reply-To: <20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org>
Overall Series Review
Subject: drm/amdgpu/discovery: Add braces to case statements in amdgpu_discovery_table_check()
Author: Nathan Chancellor <nathan@kernel.org>
Patches: 1
Reviewed: 2026-03-13T13:44:39.541822
---
This is a single-patch fix from Nathan Chancellor addressing a clang C23 compatibility warning/error in `amdgpu_discovery.c`. The issue is well-known: in C11/C17, a `case` label cannot be directly followed by a declaration — only by a statement. Clang flags this as `-Wc23-extensions` since C23 relaxes this restriction, but the kernel currently targets C11. The fix is the standard, idiomatic solution: wrap each case body in braces to create a compound statement, which allows declarations at the top.
**Verdict: The patch is correct and ready to merge.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 21:46 [PATCH] drm/amdgpu/discovery: Add braces to case statements in amdgpu_discovery_table_check() Nathan Chancellor
2026-03-13 3:44 ` Claude Code Review Bot [this message]
2026-03-13 3:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox