From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu/discovery: Add braces to case statements in amdgpu_discovery_table_check() Date: Fri, 13 Mar 2026 13:44:39 +1000 Message-ID: In-Reply-To: <20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org> References: <20260312-amdgpu-fix-clang-c23-extensions-v1-1-59883120a451@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu/discovery: Add braces to case statements in amdgpu_disc= overy_table_check() Author: Nathan Chancellor Patches: 1 Reviewed: 2026-03-13T13:44:39.541822 --- This is a single-patch fix from Nathan Chancellor addressing a clang C23 co= mpatibility warning/error in `amdgpu_discovery.c`. The issue is well-known:= in C11/C17, a `case` label cannot be directly followed by a declaration = =E2=80=94 only by a statement. Clang flags this as `-Wc23-extensions` since= C23 relaxes this restriction, but the kernel currently targets C11. The fi= x is the standard, idiomatic solution: wrap each case body in braces to cre= ate a compound statement, which allows declarations at the top. **Verdict: The patch is correct and ready to merge.** --- Generated by Claude Code Patch Reviewer