From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: Fix refcount shown via debugfs for encoder_bridges_show()
Date: Fri, 13 Mar 2026 14:28:00 +1000 [thread overview]
Message-ID: <review-overall-20260312-drm-misc-next-2026-03-05-fix-encoder-bridges-refcount-v1-1-b9ba3d844732@nxp.com> (raw)
In-Reply-To: <20260312-drm-misc-next-2026-03-05-fix-encoder-bridges-refcount-v1-1-b9ba3d844732@nxp.com>
Overall Series Review
Subject: drm/bridge: Fix refcount shown via debugfs for encoder_bridges_show()
Author: Liu Ying <victor.liu@nxp.com>
Patches: 2
Reviewed: 2026-03-13T14:28:00.934943
---
This is a single-patch fix for a debugfs display issue where `encoder_bridges_show()` reports an inflated refcount (4 instead of the expected 3) because `drm_for_each_bridge_in_chain_scoped()` holds an extra reference during iteration. The bug analysis is correct and the fix works, but the implementation is over-engineered — it adds two wrapper functions and a `bool scoped` parameter when a simpler approach would suffice.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 6:05 [PATCH] drm/bridge: Fix refcount shown via debugfs for encoder_bridges_show() Liu Ying
2026-03-12 17:30 ` Luca Ceresoli
2026-03-13 4:28 ` Claude Code Review Bot [this message]
2026-03-13 4:28 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260312-drm-misc-next-2026-03-05-fix-encoder-bridges-refcount-v1-1-b9ba3d844732@nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox