Claude review: soc/qcom/ubwc: rework UBWC configuration database

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: soc/qcom/ubwc: rework UBWC configuration database
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 28
Reviewed: 2026-03-13T14:12:48.506156

---

This is a well-structured 27-patch series from Dmitry Baryshkov (with one patch from Konrad Dybcio) that reworks the Qualcomm UBWC configuration database. The core insight is that many per-SoC UBWC configuration values are derivable from the UBWC version number, and MDSS register programming should be keyed off MDSS hardware revision rather than UBWC decoder version.

**Strengths:**
- Clean incremental approach: introduce helpers (patches 2-4), migrate consumers (patches 5-17), then remove now-unused database fields (patches 21-27)
- The final state is much cleaner — config reduced to `ubwc_enc_version`, `highest_bank_bit`, and `flags`
- Patch 1 correctly identifies that UBWC register programming depends on MDSS core revision, not UBWC version
- The deduplication in patch 27 is a clear win — ~30 unique structs reduced to ~15

**Concerns:**
- Merge dependency on another series (iris UBWC patches) requiring cross-tree coordination
- Several behavioral corrections embedded within refactoring patches (sc8180x macrotile, bank_spread for several SoCs) that should be more explicitly called out

Overall the series is correct and a worthwhile cleanup. Specific issues noted below.

---
Generated by Claude Code Patch Reviewer