Claude review: drm: bridge: ti-sn65dsi83: Improve dual-link LVDS support

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: bridge: ti-sn65dsi83: Improve dual-link LVDS support
Author: Sudarshan Shetty <tessolveupstream@gmail.com>
Patches: 8
Reviewed: 2026-03-13T14:32:11.443355

---

This series attempts to improve dual-link LVDS support for the TI SN65DSI84 bridge driver by adding a new DT property `ti,dual-link-video-mode` and hardcoding a set of register values when that property is present. The approach has **fundamental design problems**: rather than computing the correct register values from the display mode timing (divided by 2 for dual-link), the patch overwrites previously-programmed registers with magic hardcoded constants from the "TI DSI-Tuner tool." This makes the configuration panel-specific and non-generic, defeating the purpose of a general-purpose driver. The existing driver already detects dual-link via the `lvds_dual_link` flag from the OF graph ports — the cover letter's stated goal of "dividing horizontal timings by 2" would be better achieved by adjusting the existing timing calculations based on `ctx->lvds_dual_link`, not by adding a new boolean property that overwrites everything with fixed values.

---

---
Generated by Claude Code Patch Reviewer