From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: ti-sn65dsi83: Improve dual-link LVDS support Date: Fri, 13 Mar 2026 14:32:11 +1000 Message-ID: In-Reply-To: <20260312043743.261475-1-tessolveupstream@gmail.com> References: <20260312043743.261475-1-tessolveupstream@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: bridge: ti-sn65dsi83: Improve dual-link LVDS support Author: Sudarshan Shetty Patches: 8 Reviewed: 2026-03-13T14:32:11.443355 --- This series attempts to improve dual-link LVDS support for the TI SN65DSI84= bridge driver by adding a new DT property `ti,dual-link-video-mode` and ha= rdcoding a set of register values when that property is present. The approa= ch has **fundamental design problems**: rather than computing the correct r= egister values from the display mode timing (divided by 2 for dual-link), t= he patch overwrites previously-programmed registers with magic hardcoded co= nstants from the "TI DSI-Tuner tool." This makes the configuration panel-sp= ecific and non-generic, defeating the purpose of a general-purpose driver. = The existing driver already detects dual-link via the `lvds_dual_link` flag= from the OF graph ports =E2=80=94 the cover letter's stated goal of "divid= ing horizontal timings by 2" would be better achieved by adjusting the exis= ting timing calculations based on `ctx->lvds_dual_link`, not by adding a ne= w boolean property that overwrites everything with fixed values. --- --- Generated by Claude Code Patch Reviewer