From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Panel Replay BW optimization
Date: Fri, 13 Mar 2026 14:30:26 +1000 [thread overview]
Message-ID: <review-overall-20260312050035.3493690-1-animesh.manna@intel.com> (raw)
In-Reply-To: <20260312050035.3493690-1-animesh.manna@intel.com>
Overall Series Review
Subject: Panel Replay BW optimization
Author: Animesh Manna <animesh.manna@intel.com>
Patches: 13
Reviewed: 2026-03-13T14:30:26.626654
---
This is a v7 3-patch series adding Panel Replay bandwidth optimization support for DP 2.0 tunneling in the i915 display driver. The concept is straightforward: when a Panel Replay-enabled DP panel is idle with the link on, unused bandwidth can be reclaimed by external display agents (e.g., USB4 data). The series adds infrastructure to query the tunnel bridge's capability, programs the hardware register bit to enable it, and disables Panel Replay entirely when tunneling is active but the bridge doesn't support the optimization (per DP spec requirement).
The series is generally clean and well-structured for a v7. A few issues noted below, ranging from a doc typo to a potential concern about deactivation path completeness.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-13 4:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 5:00 [PATCH v7 0/3] Panel Replay BW optimization Animesh Manna
2026-03-12 5:00 ` [PATCH v7 1/3] drm/i915/display: Add drm helper to check pr optimization support Animesh Manna
2026-03-12 6:40 ` Hogander, Jouni
2026-03-12 8:36 ` Manna, Animesh
2026-03-13 4:30 ` Claude review: " Claude Code Review Bot
2026-03-12 5:00 ` [PATCH v7 2/3] drm/i915/display: Panel Replay BW optimization for DP2.0 tunneling Animesh Manna
2026-03-12 6:44 ` Hogander, Jouni
2026-03-12 8:44 ` Manna, Animesh
2026-03-13 4:30 ` Claude review: " Claude Code Review Bot
2026-03-12 5:00 ` [PATCH v7 3/3] drm/i915/display: Disable Panel Replay for DP-tunneling without optimization Animesh Manna
2026-03-12 6:17 ` Hogander, Jouni
2026-03-12 8:33 ` Manna, Animesh
2026-03-13 4:30 ` Claude review: " Claude Code Review Bot
2026-03-12 8:05 ` [PATCH v7 0/3] Panel Replay BW optimization Hogander, Jouni
2026-03-12 8:41 ` Manna, Animesh
2026-03-12 15:18 ` Imre Deak
2026-03-13 4:30 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260312050035.3493690-1-animesh.manna@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox