From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: firmware: qcom: Add OP-TEE PAS service support
Date: Fri, 13 Mar 2026 14:26:31 +1000 [thread overview]
Message-ID: <review-overall-20260312062756.694390-1-sumit.garg@kernel.org> (raw)
In-Reply-To: <20260312062756.694390-1-sumit.garg@kernel.org>
Overall Series Review
Subject: firmware: qcom: Add OP-TEE PAS service support
Author: Sumit Garg <sumit.garg@kernel.org>
Patches: 16
Reviewed: 2026-03-13T14:26:31.172338
---
This is a 15-patch series that introduces a generic Peripheral Authentication Service (PAS) abstraction layer for Qualcomm platforms, enabling both the existing SCM (QTEE) backend and a new OP-TEE TEE-bus-based backend. The overall design is reasonable — a common ops-based dispatch layer sits between client drivers and TZ backends. The migration of all client drivers is mechanical and clean. However, there are several architectural and correctness concerns, particularly around the global singleton ops pointer pattern (no locking, no refcounting), unsafe type-punning via casts between `qcom_scm_pas_context` and `qcom_pas_context`, and a return type mismatch in the ops vtable.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 4:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 6:27 [PATCH v2 00/15] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-03-12 6:27 ` [PATCH v2 01/15] arm64: dts: qcom: kodiak: Add EL2 overlay Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 02/15] firmware: qcom: Add a generic PAS service Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 03/15] firmware: qcom_scm: Migrate to " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 04/15] firmware: qcom: Add a PAS TEE service Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 05/15] remoteproc: qcom_q6v5_pas: Switch over to generic PAS TZ APIs Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 06/15] remoteproc: qcom_q6v5_mss: Switch " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 07/15] soc: qcom: mdtloader: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 08/15] remoteproc: qcom_wcnss: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 09/15] remoteproc: qcom: Select QCOM_PAS_TEE service backend Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 10/15] drm/msm: Switch to generic PAS TZ APIs Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 11/15] media: qcom: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 12/15] net: ipa: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 13/15] wifi: ath12k: " Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 14/15] firmware: qcom_scm: Remove SCM PAS wrappers Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-12 6:27 ` [PATCH v2 15/15] MAINTAINERS: Add maintainer entry for Qualcomm PAS TZ service Sumit Garg
2026-03-13 4:26 ` Claude review: " Claude Code Review Bot
2026-03-13 4:26 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-06 10:50 [PATCH 00/14] firmware: qcom: Add OP-TEE PAS service support Sumit Garg
2026-03-08 22:59 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260312062756.694390-1-sumit.garg@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox