From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: firmware: qcom: Add OP-TEE PAS service support Date: Fri, 13 Mar 2026 14:26:31 +1000 Message-ID: In-Reply-To: <20260312062756.694390-1-sumit.garg@kernel.org> References: <20260312062756.694390-1-sumit.garg@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: firmware: qcom: Add OP-TEE PAS service support Author: Sumit Garg Patches: 16 Reviewed: 2026-03-13T14:26:31.172338 --- This is a 15-patch series that introduces a generic Peripheral Authenticati= on Service (PAS) abstraction layer for Qualcomm platforms, enabling both th= e existing SCM (QTEE) backend and a new OP-TEE TEE-bus-based backend. The o= verall design is reasonable =E2=80=94 a common ops-based dispatch layer sit= s between client drivers and TZ backends. The migration of all client drive= rs is mechanical and clean. However, there are several architectural and co= rrectness concerns, particularly around the global singleton ops pointer pa= ttern (no locking, no refcounting), unsafe type-punning via casts between `= qcom_scm_pas_context` and `qcom_pas_context`, and a return type mismatch in= the ops vtable. --- --- Generated by Claude Code Patch Reviewer