From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] drm/shmem-helper: Fix Map huge page mapping in fault handler
Date: Fri, 13 Mar 2026 13:58:40 +1000 [thread overview]
Message-ID: <review-overall-20260312173227.7e9f0389@fedora> (raw)
In-Reply-To: <20260312173227.7e9f0389@fedora>
Overall Series Review
Subject: Re: [PATCH] drm/shmem-helper: Fix Map huge page mapping in fault handler
Author: Boris Brezillon <boris.brezillon@collabora.com>
Patches: 2
Reviewed: 2026-03-13T13:58:40.191908
---
This is a single-patch fix for a real race condition in the DRM shmem helper's fault handler, where two concurrent page faults within the same PMD range can collide — one installing a PMD mapping via `vmf_insert_pfn_pmd()` and the other trying to install a PTE mapping via `vmf_insert_pfn()`. The fix correctly separates the huge page mapping into a dedicated `.huge_fault` callback, which is the proper kernel mechanism for handling PMD-sized faults. The approach mirrors what `vfio_pci_core.c` already does and is the right architectural direction.
However, there are several issues with the implementation that should be addressed.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-13 3:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 15:50 [PATCH] drm/shmem-helper: Fix Map huge page mapping in fault handler Pedro Demarchi Gomes
2026-03-12 16:32 ` Boris Brezillon
2026-03-13 3:58 ` Claude review: " Claude Code Review Bot
2026-03-13 3:58 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260312173227.7e9f0389@fedora \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox