From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] drm/shmem-helper: Fix Map huge page mapping in fault handler Date: Fri, 13 Mar 2026 13:58:40 +1000 Message-ID: In-Reply-To: <20260312173227.7e9f0389@fedora> References: <20260312173227.7e9f0389@fedora> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] drm/shmem-helper: Fix Map huge page mapping in fault h= andler Author: Boris Brezillon Patches: 2 Reviewed: 2026-03-13T13:58:40.191908 --- This is a single-patch fix for a real race condition in the DRM shmem helpe= r's fault handler, where two concurrent page faults within the same PMD ran= ge can collide =E2=80=94 one installing a PMD mapping via `vmf_insert_pfn_p= md()` and the other trying to install a PTE mapping via `vmf_insert_pfn()`.= The fix correctly separates the huge page mapping into a dedicated `.huge_= fault` callback, which is the proper kernel mechanism for handling PMD-size= d faults. The approach mirrors what `vfio_pci_core.c` already does and is t= he right architectural direction. However, there are several issues with the implementation that should be ad= dressed. --- Generated by Claude Code Patch Reviewer