From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/colorop: Fix blob property reference tracking in state lifecycle
Date: Fri, 13 Mar 2026 13:48:40 +1000 [thread overview]
Message-ID: <review-overall-20260312204145.829714-1-harry.wentland@amd.com> (raw)
In-Reply-To: <20260312204145.829714-1-harry.wentland@amd.com>
Overall Series Review
Subject: drm/colorop: Fix blob property reference tracking in state lifecycle
Author: Harry Wentland <harry.wentland@amd.com>
Patches: 2
Reviewed: 2026-03-13T13:48:40.828711
---
This is a single-patch fix for blob property reference leaks in the `drm_colorop` state lifecycle. The patch correctly identifies real bugs: `drm_colorop_atomic_destroy_state()` was calling `kfree(state)` without releasing the blob reference on `state->data`, and `drm_colorop_reset()` was similarly leaking. The fix follows the well-established pattern from `drm_crtc` state helpers. The patch is straightforward, correct, and appropriate for stable backporting.
**Verdict: Looks good, with minor observations below.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 3:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 20:41 [PATCH] drm/colorop: Fix blob property reference tracking in state lifecycle Harry Wentland
2026-03-12 21:14 ` Alex Hung
2026-03-13 3:48 ` Claude Code Review Bot [this message]
2026-03-13 3:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260312204145.829714-1-harry.wentland@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox