From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/imagination: Improve power off sequence Date: Sat, 14 Mar 2026 07:22:39 +1000 Message-ID: In-Reply-To: <20260313-b4-staging-layout_mars_base-v2-0-9e3c251d278e@imgtec.com> References: <20260313-b4-staging-layout_mars_base-v2-0-9e3c251d278e@imgtec.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/imagination: Improve power off sequence Author: Brajesh Gupta Patches: 3 Reviewed: 2026-03-14T07:22:39.772730 --- This is a 2-patch series for the `drm/imagination` (PowerVR) driver that improves the firmware power-off sequence for devices with the `LAYOUT_MARS` hardware configuration. In LAYOUT_MARS, the firmware MCU has moved from the Sidekick domain to a new Mars domain, so the kernel must skip Sidekick/SLC idle polling (the firmware handles those) and instead poll the MARS_IDLE register. The second patch skips the second-thread DM association write for non-META firmware processors (which only have one thread). The changes are logically sound and well-structured. There are a few minor issues worth flagging. --- Generated by Claude Code Patch Reviewer