From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: cgroup/dmem,drm/ttm: Improve protection in contended cases Date: Sat, 14 Mar 2026 07:10:15 +1000 Message-ID: In-Reply-To: <20260313-dmemcg-aggressive-protect-v6-0-7c71cc1492db@gmx.de> References: <20260313-dmemcg-aggressive-protect-v6-0-7c71cc1492db@gmx.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: cgroup/dmem,drm/ttm: Improve protection in contended cases Author: Natalie Vock Patches: 12 Reviewed: 2026-03-14T07:10:15.097178 --- This is v6 of a series by Natalie Vock that improves dmem cgroup protection= enforcement in TTM. The core problem is well-motivated: when VRAM is fille= d by unprotected applications, TTM falls back to GTT for protected allocati= ons without ever attempting eviction, defeating the purpose of cgroup prote= ction. The series adds infrastructure (protection queries, common ancestor = helpers), refactors TTM allocation flow, decouples cgroup charging from res= ource allocation, and then uses all of this to trigger eviction for protect= ed allocations even when `force_space` is not set. The series is well-structured with good incremental patches, clear commit m= essages, and has clearly benefited from multiple rounds of review (Tvrtko's= R-b on patch 3). The overall approach is sound =E2=80=94 it correctly mode= ls the memcg protection semantics (min vs low) and handles the subtree/sibl= ing distinction properly. A few issues are noted below, mostly minor. --- Generated by Claude Code Patch Reviewer