* [PATCH v2] dt-bindings: display: panel: Align style of "true" properties
@ 2026-03-13 8:20 Krzysztof Kozlowski
2026-03-13 21:18 ` Claude review: " Claude Code Review Bot
2026-03-13 21:18 ` Claude Code Review Bot
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-13 8:20 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dzmitry Sankouski,
Tomi Valkeinen, Laurent Pinchart, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Krzysztof Kozlowski
For code readability, several bindings which list allowed properties
with ": true" syntax group them in one place, without line breaks
between each. Align a few bindings to match this style. No functional
impact.
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Changes in v2:
- Drop applied patches 1-4
- Rebase (jadard,jd9365da-h3.yaml change is gone)
- Link to v1: https://patch.msgid.link/20260306-dt-bindings-display-panel-clean-v1-0-3086eda1efaf@oss.qualcomm.com
BR,
Krzysztof
---
.../devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml | 1 -
Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml | 3 ---
.../devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml | 1 +
.../devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml | 1 +
.../devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml | 5 ++---
.../devicetree/bindings/display/panel/novatek,nt35510.yaml | 3 ++-
.../devicetree/bindings/display/panel/renesas,r61307.yaml | 3 +--
.../devicetree/bindings/display/panel/renesas,r69328.yaml | 1 -
.../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 5 ++---
.../bindings/display/panel/sony,tulip-truly-nt35521.yaml | 2 --
.../devicetree/bindings/display/panel/startek,kd070fhfid015.yaml | 7 ++-----
11 files changed, 11 insertions(+), 21 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
index 92df69e80a82..f288fa2390c9 100644
--- a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
+++ b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
@@ -28,7 +28,6 @@ properties:
port: true
reset-gpios: true
-
backlight: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
index 182a2b825e1c..84e840e0224f 100644
--- a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
@@ -33,11 +33,8 @@ properties:
maxItems: 1
reset-gpios: true
-
backlight: true
-
rotation: true
-
port: true
vcc-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
index 5fcea62fd58f..2f49a6bbf3d7 100644
--- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
+++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
@@ -25,6 +25,7 @@ properties:
backlight: true
port: true
reset-gpios: true
+
iovcc-supply:
description: regulator that supplies the iovcc voltage
vci-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
index b0e2c82232d3..3f56047f4469 100644
--- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
+++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
@@ -24,6 +24,7 @@ properties:
backlight: true
port: true
reset-gpios: true
+
iovcc-supply:
description: regulator that supplies the iovcc voltage
vcc-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
index 74ff772973d6..b8b153a6e6cc 100644
--- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
+++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
@@ -22,7 +22,6 @@ properties:
- mantix,mlaf057we51-x
- ys,ys57pss36bh5gq
- port: true
reg:
maxItems: 1
description: DSI virtual channel
@@ -36,13 +35,13 @@ properties:
vddi-supply:
description: 1.8V I/O voltage supply
- reset-gpios: true
-
mantix,tp-rstn-gpios:
maxItems: 1
description: second reset line that triggers DSI config load
backlight: true
+ port: true
+ reset-gpios: true
required:
- compatible
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
index b39fd0c5a48a..43d134daf0ac 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -28,13 +28,14 @@ properties:
reg:
maxItems: 1
- reset-gpios: true
vdd-supply:
description: regulator that supplies the vdd voltage
vddi-supply:
description: regulator that supplies the vddi voltage
+
backlight: true
port: true
+ reset-gpios: true
required:
- compatible
diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
index 90cce221c0d1..3d7761717b74 100644
--- a/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
+++ b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
@@ -33,8 +33,6 @@ properties:
iovcc-supply:
description: Regulator for 1.8V IO power supply.
- backlight: true
-
renesas,gamma:
$ref: /schemas/types.yaml#/definitions/uint32
description:
@@ -51,6 +49,7 @@ properties:
type: boolean
description: digital contrast adjustment
+ backlight: true
reset-gpios: true
port: true
diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
index 1cd219b510ee..740185f778a1 100644
--- a/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
+++ b/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
@@ -33,7 +33,6 @@ properties:
description: Regulator for 1.8V IO power supply.
backlight: true
-
reset-gpios: true
port: true
diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index 4ae152cc55e0..ebfc825b8346 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -33,7 +33,6 @@ properties:
# Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
- xingbangda,xbd599
- port: true
reg:
maxItems: 1
description: DSI virtual channel
@@ -44,9 +43,9 @@ properties:
iovcc-supply:
description: I/O voltage supply
- reset-gpios: true
-
backlight: true
+ port: true
+ reset-gpios: true
rotation: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml b/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
index a58a31349757..85c5dee65383 100644
--- a/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
@@ -31,9 +31,7 @@ properties:
description: Negative 5V supply
reset-gpios: true
-
enable-gpios: true
-
port: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
index 0819f38a9d2c..7fd9364fa385 100644
--- a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
+++ b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
@@ -16,8 +16,6 @@ properties:
compatible:
const: startek,kd070fhfid015
- enable-gpios: true
-
iovcc-supply:
description: Reference to the regulator powering the panel IO pins.
@@ -25,11 +23,10 @@ properties:
maxItems: 1
description: DSI virtual channel
- reset-gpios: true
-
+ enable-gpios: true
port: true
-
power-supply: true
+ reset-gpios: true
required:
- compatible
---
base-commit: 5c9e55fecf9365890c64f14761a80f9413a3b1d1
change-id: 20260306-dt-bindings-display-panel-clean-3ddd8e087ef2
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Claude review: dt-bindings: display: panel: Align style of "true" properties
2026-03-13 8:20 [PATCH v2] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
@ 2026-03-13 21:18 ` Claude Code Review Bot
2026-03-13 21:18 ` Claude Code Review Bot
1 sibling, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-03-13 21:18 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: dt-bindings: display: panel: Align style of "true" properties
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-03-14T07:18:05.903753
---
This is a single-patch cosmetic cleanup (v2) from Krzysztof Kozlowski that normalizes the whitespace style in DT binding YAML files for display panels. The goal is to group all `": true"` property declarations together without blank lines between them, and to separate them with a blank line from properties that have sub-fields (like `description:` or `maxItems:`). This is a well-established convention in DT bindings.
The patch is straightforward, purely cosmetic, and carries no functional risk. It already has a Reviewed-by from Neil Armstrong. No issues found.
**Recommendation: Looks good. No concerns.**
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Claude review: dt-bindings: display: panel: Align style of "true" properties
2026-03-13 8:20 [PATCH v2] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
2026-03-13 21:18 ` Claude review: " Claude Code Review Bot
@ 2026-03-13 21:18 ` Claude Code Review Bot
1 sibling, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-03-13 21:18 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Changes across 11 YAML binding files:**
The patch consistently applies two style rules:
1. **Remove blank lines between consecutive `": true"` properties** — e.g., in `himax,hx8394.yaml`:
```yaml
- reset-gpios: true
-
- backlight: true
-
- rotation: true
-
- port: true
+ reset-gpios: true
+ backlight: true
+ rotation: true
+ port: true
```
2. **Add a blank line between the `": true"` block and properties with sub-fields** — e.g., in `leadtek,ltk050h3146w.yaml`:
```yaml
reset-gpios: true
+
iovcc-supply:
description: regulator that supplies the iovcc voltage
```
3. **Reorder some `": true"` properties to group them together at the end of the properties block** — e.g., in `mantix,mlaf057we51-x.yaml`, `port: true` and `reset-gpios: true` are moved from their scattered locations to a grouped block alongside `backlight: true`. Similarly in `rocktech,jh057n00900.yaml`, `novatek,nt35510.yaml`, and `startek,kd070fhfid015.yaml`.
**Assessment:** All changes are consistent and correctly applied. The reordering of properties within the `properties:` block in YAML schemas has no functional impact since property order does not affect DT binding validation. The patch improves readability by making the style uniform across these files.
No issues found. This is a clean cosmetic patch ready to be applied.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes
@ 2026-03-06 12:02 Krzysztof Kozlowski
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-06 12:02 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dzmitry Sankouski,
Tomi Valkeinen, Laurent Pinchart, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Krzysztof Kozlowski
I would expect this going via display, but that does not happen often,
so Rob's tree?
BR,
Krzysztof
---
Krzysztof Kozlowski (5):
dt-bindings: display: samsung,s6d7aa0: Document port
dt-bindings: display: innolux,p097pfg: Document ports
dt-bindings: display: panel: Drop redundant properties
dt-bindings: display: panel: Align style of additionalProperties
dt-bindings: display: panel: Align style of "true" properties
.../bindings/display/panel/abt,y030xx067a.yaml | 5 -----
.../display/panel/advantech,idk-1110wr.yaml | 4 ++--
.../display/panel/advantech,idk-2121wr.yaml | 4 ++--
.../display/panel/bananapi,s070wv20-ct16.yaml | 4 ++--
.../bindings/display/panel/dlc,dlc0700yzg-1.yaml | 4 ++--
.../display/panel/feiyang,fy07024di26a30d.yaml | 1 -
.../bindings/display/panel/himax,hx83112a.yaml | 2 --
.../bindings/display/panel/himax,hx8394.yaml | 7 ++----
.../bindings/display/panel/ilitek,ili9163.yaml | 4 ----
.../bindings/display/panel/ilitek,ili9322.yaml | 3 ---
.../bindings/display/panel/ilitek,ili9341.yaml | 6 ++---
.../bindings/display/panel/innolux,ej030na.yaml | 5 -----
.../bindings/display/panel/innolux,p097pfg.yaml | 26 +++++++++++++++++++++-
.../bindings/display/panel/jadard,jd9365da-h3.yaml | 2 --
.../display/panel/kingdisplay,kd035g6-54nt.yaml | 5 -----
.../display/panel/leadtek,ltk050h3146w.yaml | 1 +
.../display/panel/leadtek,ltk500hd1829.yaml | 1 +
.../bindings/display/panel/lgphilips,lb035q02.yaml | 4 ----
.../display/panel/mantix,mlaf057we51-x.yaml | 5 ++---
.../display/panel/mitsubishi,aa104xd12.yaml | 4 ++--
.../display/panel/mitsubishi,aa121td01.yaml | 4 ++--
.../bindings/display/panel/nec,nl8048hl11.yaml | 4 ----
.../bindings/display/panel/novatek,nt35510.yaml | 3 ++-
.../bindings/display/panel/novatek,nt36523.yaml | 3 ---
.../bindings/display/panel/novatek,nt36672a.yaml | 3 ---
.../bindings/display/panel/orisetech,otm8009a.yaml | 4 ++--
.../bindings/display/panel/pda,91-00156-a0.yaml | 4 ++--
.../bindings/display/panel/raydium,rm68200.yaml | 4 ++--
.../bindings/display/panel/raydium,rm692e5.yaml | 2 --
.../bindings/display/panel/renesas,r61307.yaml | 3 +--
.../bindings/display/panel/renesas,r69328.yaml | 1 -
.../display/panel/rocktech,jh057n00900.yaml | 5 ++---
.../bindings/display/panel/samsung,atna33xc20.yaml | 4 ++--
.../bindings/display/panel/samsung,ld9040.yaml | 4 ----
.../bindings/display/panel/samsung,lms380kf01.yaml | 6 -----
.../bindings/display/panel/samsung,lms397kf04.yaml | 6 -----
.../bindings/display/panel/samsung,s6d27a1.yaml | 6 -----
.../bindings/display/panel/samsung,s6d7aa0.yaml | 8 +++++++
.../bindings/display/panel/samsung,s6e3ha8.yaml | 4 ----
.../bindings/display/panel/samsung,s6e63m0.yaml | 2 --
.../bindings/display/panel/sgd,gktw70sdae4se.yaml | 4 ++--
.../bindings/display/panel/sitronix,st7701.yaml | 6 -----
.../bindings/display/panel/sitronix,st7789v.yaml | 6 -----
.../bindings/display/panel/sony,acx565akm.yaml | 4 ----
.../display/panel/sony,tulip-truly-nt35521.yaml | 2 --
.../display/panel/startek,kd070fhfid015.yaml | 11 ++++-----
.../devicetree/bindings/display/panel/tpo,td.yaml | 5 -----
.../bindings/display/panel/visionox,r66451.yaml | 4 ++--
.../bindings/display/panel/visionox,rm69299.yaml | 4 ++--
.../bindings/display/panel/visionox,vtdr6130.yaml | 4 ++--
50 files changed, 78 insertions(+), 149 deletions(-)
---
base-commit: c025f6cf4209e1542ec2afebe49f42bbaf1a5c7b
change-id: 20260306-dt-bindings-display-panel-clean-3ddd8e087ef2
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
@ 2026-03-06 12:02 ` Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-06 12:02 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dzmitry Sankouski,
Tomi Valkeinen, Laurent Pinchart, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Krzysztof Kozlowski
For code readability, several bindings which list allowed properties
with ": true" syntax group them in one place, without line breaks
between each. Align a few bindings to match this style. No functional
impact.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml | 1 -
Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml | 3 ---
.../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml | 2 --
.../devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml | 1 +
.../devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml | 1 +
.../devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml | 5 ++---
.../devicetree/bindings/display/panel/novatek,nt35510.yaml | 3 ++-
.../devicetree/bindings/display/panel/renesas,r61307.yaml | 3 +--
.../devicetree/bindings/display/panel/renesas,r69328.yaml | 1 -
.../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 5 ++---
.../bindings/display/panel/sony,tulip-truly-nt35521.yaml | 2 --
.../devicetree/bindings/display/panel/startek,kd070fhfid015.yaml | 7 ++-----
12 files changed, 11 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
index 92df69e80a82..f288fa2390c9 100644
--- a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
+++ b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
@@ -28,7 +28,6 @@ properties:
port: true
reset-gpios: true
-
backlight: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
index 182a2b825e1c..84e840e0224f 100644
--- a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
@@ -33,11 +33,8 @@ properties:
maxItems: 1
reset-gpios: true
-
backlight: true
-
rotation: true
-
port: true
vcc-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
index 5802fb3c9ffe..2fa07ec55b08 100644
--- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
@@ -35,9 +35,7 @@ properties:
description: supply regulator for VCCIO, usually 1.8V
reset-gpios: true
-
backlight: true
-
port: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
index 5fcea62fd58f..2f49a6bbf3d7 100644
--- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
+++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
@@ -25,6 +25,7 @@ properties:
backlight: true
port: true
reset-gpios: true
+
iovcc-supply:
description: regulator that supplies the iovcc voltage
vci-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
index b0e2c82232d3..3f56047f4469 100644
--- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
+++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
@@ -24,6 +24,7 @@ properties:
backlight: true
port: true
reset-gpios: true
+
iovcc-supply:
description: regulator that supplies the iovcc voltage
vcc-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
index 74ff772973d6..b8b153a6e6cc 100644
--- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
+++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
@@ -22,7 +22,6 @@ properties:
- mantix,mlaf057we51-x
- ys,ys57pss36bh5gq
- port: true
reg:
maxItems: 1
description: DSI virtual channel
@@ -36,13 +35,13 @@ properties:
vddi-supply:
description: 1.8V I/O voltage supply
- reset-gpios: true
-
mantix,tp-rstn-gpios:
maxItems: 1
description: second reset line that triggers DSI config load
backlight: true
+ port: true
+ reset-gpios: true
required:
- compatible
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
index b39fd0c5a48a..43d134daf0ac 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -28,13 +28,14 @@ properties:
reg:
maxItems: 1
- reset-gpios: true
vdd-supply:
description: regulator that supplies the vdd voltage
vddi-supply:
description: regulator that supplies the vddi voltage
+
backlight: true
port: true
+ reset-gpios: true
required:
- compatible
diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
index 90cce221c0d1..3d7761717b74 100644
--- a/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
+++ b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
@@ -33,8 +33,6 @@ properties:
iovcc-supply:
description: Regulator for 1.8V IO power supply.
- backlight: true
-
renesas,gamma:
$ref: /schemas/types.yaml#/definitions/uint32
description:
@@ -51,6 +49,7 @@ properties:
type: boolean
description: digital contrast adjustment
+ backlight: true
reset-gpios: true
port: true
diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
index 1cd219b510ee..740185f778a1 100644
--- a/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
+++ b/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
@@ -33,7 +33,6 @@ properties:
description: Regulator for 1.8V IO power supply.
backlight: true
-
reset-gpios: true
port: true
diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index 4ae152cc55e0..ebfc825b8346 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -33,7 +33,6 @@ properties:
# Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
- xingbangda,xbd599
- port: true
reg:
maxItems: 1
description: DSI virtual channel
@@ -44,9 +43,9 @@ properties:
iovcc-supply:
description: I/O voltage supply
- reset-gpios: true
-
backlight: true
+ port: true
+ reset-gpios: true
rotation: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml b/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
index a58a31349757..85c5dee65383 100644
--- a/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
@@ -31,9 +31,7 @@ properties:
description: Negative 5V supply
reset-gpios: true
-
enable-gpios: true
-
port: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
index 0819f38a9d2c..7fd9364fa385 100644
--- a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
+++ b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
@@ -16,8 +16,6 @@ properties:
compatible:
const: startek,kd070fhfid015
- enable-gpios: true
-
iovcc-supply:
description: Reference to the regulator powering the panel IO pins.
@@ -25,11 +23,10 @@ properties:
maxItems: 1
description: DSI virtual channel
- reset-gpios: true
-
+ enable-gpios: true
port: true
-
power-supply: true
+ reset-gpios: true
required:
- compatible
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Claude review: dt-bindings: display: panel: Align style of "true" properties
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
@ 2026-03-08 22:53 ` Claude Code Review Bot
0 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-03-08 22:53 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
Groups `": true"` property declarations together without blank line separations, and alphabetically sorts them where applicable (e.g., `backlight`, `port`, `reset-gpios`). Also moves some `": true"` properties that were scattered between other property definitions to a consolidated block.
For example in `mantix,mlaf057we51-x.yaml`, `port: true` was above `reg:` and `reset-gpios: true` was separated — the patch moves both to a clean group:
```yaml
backlight: true
port: true
reset-gpios: true
```
Pure cosmetic. The `himax,hx8394.yaml` change depends on patch 4 (which moved `additionalProperties` in that file), so the ordering within the series is correct. No issues.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-13 21:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 8:20 [PATCH v2] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
2026-03-13 21:18 ` Claude review: " Claude Code Review Bot
2026-03-13 21:18 ` Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox