From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: add basic serial device bus abstractions Date: Mon, 16 Mar 2026 12:17:34 +1000 Message-ID: In-Reply-To: <20260313-rust_serdev-v3-0-c9a3af214f7f@posteo.de> References: <20260313-rust_serdev-v3-0-c9a3af214f7f@posteo.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: rust: add basic serial device bus abstractions Author: Markus Probst Patches: 15 Reviewed: 2026-03-16T12:17:34.917979 --- This is a v3 patch series adding Rust abstractions for the Linux serial device bus (serdev) subsystem, consisting of 4 patches: a devres API change, a C-side struct modification, the main Rust abstraction, and a sample driver. The overall design follows established kernel Rust driver patterns (similar to platform, USB, auxiliary bus abstractions) and the code is well-structured. However, there are several concerns, ranging from a **critical safety issue** in the `devres::register` lifetime change, to race condition concerns in the probe/receive synchronization, and a few minor API design questions. --- Generated by Claude Code Patch Reviewer