From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ast: DisplayPort edid supports 256 bytes
Date: Sat, 14 Mar 2026 07:11:37 +1000 [thread overview]
Message-ID: <review-overall-20260313-upstream_ast_dp_edid-v1-1-2a75b7c091b2@aspeedtech.com> (raw)
In-Reply-To: <20260313-upstream_ast_dp_edid-v1-1-2a75b7c091b2@aspeedtech.com>
Overall Series Review
Subject: drm/ast: DisplayPort edid supports 256 bytes
Author: Jammy Huang <jammy_huang@aspeedtech.com>
Patches: 1
Reviewed: 2026-03-14T07:11:37.010240
---
This is a single-patch series that aims to enable reading EDID extension blocks (block 1) over the ASPEED DisplayPort interface. The change itself is a one-line fix (`block > 0` → `block > 1`), but there is a significant functional problem: the code at line 157-168 unconditionally zeroes out the extension count byte and adjusts the checksum in block 0, which contradicts the goal of this patch. If block 1 is now allowed, the EDID block 0 should actually report that an extension exists.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-13 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 10:04 [PATCH] drm/ast: DisplayPort edid supports 256 bytes Jammy Huang
2026-03-13 21:11 ` Claude review: " Claude Code Review Bot
2026-03-13 21:11 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260313-upstream_ast_dp_edid-v1-1-2a75b7c091b2@aspeedtech.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox