From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ast: DisplayPort edid supports 256 bytes Date: Sat, 14 Mar 2026 07:11:37 +1000 Message-ID: In-Reply-To: <20260313-upstream_ast_dp_edid-v1-1-2a75b7c091b2@aspeedtech.com> References: <20260313-upstream_ast_dp_edid-v1-1-2a75b7c091b2@aspeedtech.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/ast: DisplayPort edid supports 256 bytes Author: Jammy Huang Patches: 1 Reviewed: 2026-03-14T07:11:37.010240 --- This is a single-patch series that aims to enable reading EDID extension bl= ocks (block 1) over the ASPEED DisplayPort interface. The change itself is = a one-line fix (`block > 0` =E2=86=92 `block > 1`), but there is a signific= ant functional problem: the code at line 157-168 unconditionally zeroes out= the extension count byte and adjusts the checksum in block 0, which contra= dicts the goal of this patch. If block 1 is now allowed, the EDID block 0 s= hould actually report that an extension exists. --- Generated by Claude Code Patch Reviewer