From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: property: use kzalloc_flex
Date: Fri, 13 Mar 2026 13:43:38 +1000 [thread overview]
Message-ID: <review-overall-20260313000620.117065-1-rosenp@gmail.com> (raw)
In-Reply-To: <20260313000620.117065-1-rosenp@gmail.com>
Overall Series Review
Subject: drm: property: use kzalloc_flex
Author: Rosen Penev <rosenp@gmail.com>
Patches: 1
Reviewed: 2026-03-13T13:43:38.093496
---
This is a single-patch series that converts `struct drm_property` to use a flexible array member for `values[]` instead of a separately allocated pointer, using the `kzalloc_flex` helper. The conversion is straightforward and correct. The `values` pointer was never reassigned after initial allocation, `struct drm_property` is always heap-allocated via pointers, and all existing accesses to `property->values[i]` work identically with a flexible array member.
The patch is **clean and correct**. It simplifies allocation (removing one `kcalloc` and its error handling), simplifies deallocation (removing the separate `kfree(property->values)`), and adds `__counted_by` for runtime bounds checking — all good improvements.
**Recommendation: Accept / Reviewed-by worthy**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 3:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 0:06 [PATCH] drm: property: use kzalloc_flex Rosen Penev
2026-03-13 3:43 ` Claude Code Review Bot [this message]
2026-03-13 3:43 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260313000620.117065-1-rosenp@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox