From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry Date: Fri, 13 Mar 2026 13:42:08 +1000 Message-ID: In-Reply-To: <20260313015202.3660072-1-david.e.box@linux.intel.com> References: <20260313015202.3660072-1-david.e.box@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: platform/x86/intel: Add ACPI PMT discovery support and enable NVL = PMC telemetry Author: "David E. Box" Patches: 23 Reviewed: 2026-03-13T13:42:08.522056 --- This is a 22-patch series by David E. Box that adds ACPI-based PMT (Platfor= m Monitoring Technology) discovery support to the Intel VSEC/PMT subsystem = and wires it into the PMC telemetry stack for Nova Lake S platforms. The se= ries is logically structured in three phases: 1. **Patches 1=E2=80=936:** Generalize the intel_vsec driver to work with `= struct device *` instead of `struct pci_dev *`, and add ACPI discovery tabl= e plumbing. 2. **Patches 7=E2=80=9312:** Refactor the PMT class driver with pre/post de= code hooks, centralize header parsing, and add ACPI as a discovery source. 3. **Patches 13=E2=80=9322:** Wire up PMC drivers, add the new ACPI PWRM te= lemetry driver, and enable NVL SSRAM telemetry. The series is mostly well-structured with good incremental refactoring. The= early patches (1=E2=80=935) already have multiple Reviewed-by tags from pr= evious postings. However, there is one **critical ordering bug** in the cra= shlog pre-decode hook and several minor issues. --- --- Generated by Claude Code Patch Reviewer