From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu: switch XGMI sysfs show helpers to sysfs_emit_at()
Date: Sat, 14 Mar 2026 07:16:57 +1000 [thread overview]
Message-ID: <review-overall-20260313015226.39727-1-davidbaum461@gmail.com> (raw)
In-Reply-To: <20260313015226.39727-1-davidbaum461@gmail.com>
Overall Series Review
Subject: drm/amdgpu: switch XGMI sysfs show helpers to sysfs_emit_at()
Author: David Baum <davidbaum461@gmail.com>
Patches: 2
Reviewed: 2026-03-14T07:16:57.684961
---
This is a single, well-motivated cleanup patch that converts two sysfs show helpers from using `sprintf()` + a self-referencing `sysfs_emit(buf, "%s\n", buf)` pattern to the proper `sysfs_emit_at()` API. The existing code has a real bug: passing `buf` as both the destination and a `%s` argument to `sysfs_emit()` is undefined behavior (overlapping source and destination in a formatted print). The fix is correct and follows the pattern already established by the neighboring `amdgpu_xgmi_show_connected_port_num()` function.
**Verdict: Looks good.** One minor concern noted below, but it's not a blocker.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 1:52 [PATCH] drm/amdgpu: switch XGMI sysfs show helpers to sysfs_emit_at() David Baum
2026-03-13 14:04 ` Alex Deucher
2026-03-13 21:16 ` Claude Code Review Bot [this message]
2026-03-13 21:16 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260313015226.39727-1-davidbaum461@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox