From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: switch XGMI sysfs show helpers to sysfs_emit_at() Date: Sat, 14 Mar 2026 07:16:57 +1000 Message-ID: In-Reply-To: <20260313015226.39727-1-davidbaum461@gmail.com> References: <20260313015226.39727-1-davidbaum461@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: switch XGMI sysfs show helpers to sysfs_emit_at() Author: David Baum Patches: 2 Reviewed: 2026-03-14T07:16:57.684961 --- This is a single, well-motivated cleanup patch that converts two sysfs show helpers from using `sprintf()` + a self-referencing `sysfs_emit(buf, "%s\n", buf)` pattern to the proper `sysfs_emit_at()` API. The existing code has a real bug: passing `buf` as both the destination and a `%s` argument to `sysfs_emit()` is undefined behavior (overlapping source and destination in a formatted print). The fix is correct and follows the pattern already established by the neighboring `amdgpu_xgmi_show_connected_port_num()` function. **Verdict: Looks good.** One minor concern noted below, but it's not a blocker. --- Generated by Claude Code Patch Reviewer