Claude review: Arm China Linlon-D6 display controller support

Claude review: Arm China Linlon-D6 display controller support

[Claude Code Review Bot]

Overall Series Review

Subject: Arm China Linlon-D6 display controller support
Author: Cunyuan Liu <cunyuan.liu@cixtech.com>
Patches: 10
Reviewed: 2026-03-12T07:17:47.131429

---

This is a clean, minimal 3-patch series adding support for the Arm China Linlon-D6 display controller to the existing Komeda/Mali-D71 DRM driver. The approach is sound — the Linlon-D6 is described as register-compatible with Mali-D71, so reusing the D71 code path via a new compatible string with a fallback is the correct DT pattern. The changes are small and well-scoped.

One concern: the cover letter says the DT binding uses `"armchina,linlon-d6"` with a fallback to `"arm,mali-d71"`, but the **driver's `of_device_id` table only matches the specific `"armchina,linlon-d6"` compatible** — it does not rely on the fallback. This works, but it means the driver duplicates the match rather than relying on DT fallback semantics. This is consistent with how `arm,mali-d32` is handled (it also has both a binding fallback and an explicit driver match entry), so the pattern is fine.

No significant issues found. A few minor observations below.

---
Generated by Claude Code Patch Reviewer

[PATCH v2 0/3] Arm China Linlon-D6 display controller support

[Cunyuan Liu]

Adds Komeda DRM support for Arm China Linlon-D6. The IP is register-compatible
with Mali-D71, so we reuse the D71 code path.

  [1/3] dt-bindings: vendor-prefixes: add Arm Technology (China) "armchina"
  [2/3] dt-bindings: add armchina,linlon-d6 compatible (fallback to arm,mali-d71)
  [3/3] drm/komeda: add Linlon-D6 product ID and of_device_id, use D71 funcs

Changes in v2:
- PATCH [2/3]: rework compatible schema using enum as suggested by Krzysztof.

v1: https://lore.kernel.org/dri-devel/20260311055506.12023-1-cunyuan.liu@cixtech.com/

Tested on Radxa Orion O6 with Linlon-D6, basic display bring-up works as expected.

Thanks,
Cunyuan

Cunyuan Liu (3):
  dt-bindings: vendor-prefixes: Add Arm Technology (China) Co., Ltd.
  dt-bindings: display: arm,komeda: add Arm China Linlon D6 compatible
  drm/komeda: Add support for Arm China Linlon-D6

 Documentation/devicetree/bindings/display/arm,komeda.yaml | 4 +++-
 Documentation/devicetree/bindings/vendor-prefixes.yaml    | 2 ++
 drivers/gpu/drm/arm/display/include/malidp_product.h      | 1 +
 drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c          | 1 +
 drivers/gpu/drm/arm/display/komeda/komeda_drv.c           | 1 +
 5 files changed, 8 insertions(+), 1 deletion(-)

-- 
2.53.0

[PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Arm Technology (China) Co., Ltd.

[Cunyuan Liu]

Add "armchina" vendor prefix for Arm Technology (China) Co., Ltd.

Link: https://www.armchina.com/

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Cunyuan Liu <cunyuan.liu@cixtech.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index ee7fd3cfe203..c7ca7f43925b 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -172,6 +172,8 @@ patternProperties:
     description: ARM Ltd.
   "^armadeus,.*":
     description: ARMadeus Systems SARL
+  "^armchina,.*":
+    description: Arm Technology (China) Co., Ltd.
   "^armsom,.*":
     description: ArmSoM Technology Co., Ltd.
   "^arrow,.*":
-- 
2.53.0

[PATCH v2 2/3] dt-bindings: display: arm, komeda: add Arm China Linlon D6 compatible

[Cunyuan Liu]

Add the Arm China Linlon D6 display controller compatible string.

Linlon D6 is register-compatible with Mali-D71, so describe it as a
vendor-specific compatible with a fallback to "arm,mali-d71".

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Cunyuan Liu <cunyuan.liu@cixtech.com>
---
 Documentation/devicetree/bindings/display/arm,komeda.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/arm,komeda.yaml b/Documentation/devicetree/bindings/display/arm,komeda.yaml
index 3ad3eef89ca8..1afd254b6c2f 100644
--- a/Documentation/devicetree/bindings/display/arm,komeda.yaml
+++ b/Documentation/devicetree/bindings/display/arm,komeda.yaml
@@ -19,7 +19,9 @@ properties:
   compatible:
     oneOf:
       - items:
-          - const: arm,mali-d32
+          - enum:
+              - arm,mali-d32
+              - armchina,linlon-d6
           - const: arm,mali-d71
       - const: arm,mali-d71
 
-- 
2.53.0

[PATCH v2 3/3] drm/komeda: Add support for Arm China Linlon-D6

[Cunyuan Liu]

Arm China Linlon-D6 is register-compatible with the Mali-D71 display
pipeline for the purpose of basic modesetting.

On Linlon-D6, the PRODUCT_ID register is located at the same offset as on
Mali-D71 and reports 0x0060. The IP also exposes the same Komeda top-level
block layout expected by the existing d71_identify() probing flow, so we
can reuse the D71 function table to bring up the display engine.

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Cunyuan Liu <cunyuan.liu@cixtech.com>
---
 drivers/gpu/drm/arm/display/include/malidp_product.h | 1 +
 drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c     | 1 +
 drivers/gpu/drm/arm/display/komeda/komeda_drv.c      | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/arm/display/include/malidp_product.h b/drivers/gpu/drm/arm/display/include/malidp_product.h
index 16a8a2c22c42..6f954bcdf40e 100644
--- a/drivers/gpu/drm/arm/display/include/malidp_product.h
+++ b/drivers/gpu/drm/arm/display/include/malidp_product.h
@@ -20,6 +20,7 @@
 /* Mali-display product IDs */
 #define MALIDP_D71_PRODUCT_ID	0x0071
 #define MALIDP_D32_PRODUCT_ID	0x0032
+#define LINLONDP_D6_PRODUCT_ID	0x0060
 
 union komeda_config_id {
 	struct {
diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
index 80973975bfdb..f105e3a2dce2 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
@@ -628,6 +628,7 @@ d71_identify(u32 __iomem *reg_base, struct komeda_chip_info *chip)
 	switch (product_id) {
 	case MALIDP_D71_PRODUCT_ID:
 	case MALIDP_D32_PRODUCT_ID:
+	case LINLONDP_D6_PRODUCT_ID:
 		funcs = &d71_chip_funcs;
 		break;
 	default:
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
index 358c1512b087..4bb5f250e95e 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
@@ -104,6 +104,7 @@ static int komeda_platform_probe(struct platform_device *pdev)
 static const struct of_device_id komeda_of_match[] = {
 	{ .compatible = "arm,mali-d71", .data = d71_identify, },
 	{ .compatible = "arm,mali-d32", .data = d71_identify, },
+	{ .compatible = "armchina,linlon-d6", .data = d71_identify, },
 	{},
 };
 
-- 
2.53.0

Claude review: Arm China Linlon-D6 display controller support

[Claude Code Review Bot]

Overall Series Review

Subject: Arm China Linlon-D6 display controller support
Author: Cunyuan Liu <cunyuan.liu@cixtech.com>
Patches: 4
Reviewed: 2026-03-14T07:30:59.559964

---

This is a clean, well-structured 3-patch series adding support for the Arm China Linlon-D6 display controller to the existing Komeda/Mali-D71 DRM driver. The Linlon-D6 is described as register-compatible with Mali-D71, so the approach of reusing the D71 code path is sound. The series is minimal and correct — it adds only what's necessary: a vendor prefix, a DT binding compatible string, and the driver plumbing.

All three patches already carry appropriate Acked-by/Reviewed-by tags from relevant maintainers (Rob Herring for the vendor prefix, Liviu Dudau for the binding and driver patches). The v2 iteration addressed Krzysztof Kozlowski's feedback on the binding schema.

No issues found. This series looks ready to merge.

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindings: vendor-prefixes: Add Arm Technology (China) Co., Ltd.

[Claude Code Review Bot]

Patch Review

Straightforward addition of the `"^armchina,.*"` vendor prefix, correctly placed in alphabetical order between `"^armadeus,.*"` and `"^armsom,.*"`.

```yaml
+  "^armchina,.*":
+    description: Arm Technology (China) Co., Ltd.
```

No issues. Already has `Acked-by: Rob Herring (Arm)`.

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindings: display: arm, komeda: add Arm China Linlon D6 compatible

[Claude Code Review Bot]

Patch Review

Adds `armchina,linlon-d6` as a new compatible string with `arm,mali-d71` as the required fallback. The v2 rework correctly uses `enum` instead of the previous approach (as suggested by Krzysztof):

```yaml
      - items:
-          - const: arm,mali-d32
+          - enum:
+              - arm,mali-d32
+              - armchina,linlon-d6
           - const: arm,mali-d71
```

This is the correct DT binding pattern — the Linlon-D6 must be described with `compatible = "armchina,linlon-d6", "arm,mali-d71"` in the device tree, which the schema now validates. The `arm,mali-d32` case is also properly folded into the same `enum` to keep the schema clean.

No issues.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/komeda: Add support for Arm China Linlon-D6

[Claude Code Review Bot]

Patch Review

Three minimal changes:

1. **Product ID define** (`malidp_product.h:23`): `LINLONDP_D6_PRODUCT_ID` set to `0x0060`, matching what the hardware reportedly reads from the PRODUCT_ID register. The naming convention (`LINLONDP_` vs `MALIDP_`) is reasonable to distinguish the Arm China product from the Arm products.

2. **d71_identify switch case** (`d71_dev.c:631`): Adding `LINLONDP_D6_PRODUCT_ID` alongside the existing D71 and D32 cases so the probing function accepts the Linlon-D6 product ID and returns the same `d71_chip_funcs`.

3. **of_device_id table** (`komeda_drv.c:107`): Adding the `"armchina,linlon-d6"` compatible string pointing to `d71_identify`, consistent with how `arm,mali-d32` is handled.

One minor observation: the `komeda_of_match` table entry for `"armchina,linlon-d6"` will match directly without needing the `"arm,mali-d71"` fallback compatible from the DT, since both are listed. This is fine — it means the driver works whether or not the fallback is present, and the binding schema ensures the fallback is always specified in DT anyway.

No issues.

---
Generated by Claude Code Patch Reviewer