From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: [linux-next mismerge] drm/fbdev-emulation: restore drm_fb_helper_gem_is_fb() dummy
Date: Sat, 14 Mar 2026 07:12:57 +1000 [thread overview]
Message-ID: <review-overall-20260313095657.4115599-1-arnd@kernel.org> (raw)
In-Reply-To: <20260313095657.4115599-1-arnd@kernel.org>
Overall Series Review
Subject: [linux-next mismerge] drm/fbdev-emulation: restore drm_fb_helper_gem_is_fb() dummy
Author: Arnd Bergmann <arnd@kernel.org>
Patches: 1
Reviewed: 2026-03-14T07:12:57.339546
---
This is a single patch fixing a **linux-next merge conflict**, not a patch targeting drm-next directly. The patch addresses a build failure caused by conflicting commits from two different trees (drm and amdgpu) being merged together in linux-next:
1. The drm tree (commit `6d438685340d`) removed empty placeholder/stub functions from `drm_fb_helper.h`, including the `#else` block with stubs for `!CONFIG_DRM_FBDEV_EMULATION`.
2. The amdgpu tree (commit `1837c76b780a`) added a new function `drm_fb_helper_gem_is_fb()` and callers in `amdgpu_display.c` and `radeon_device.c`.
3. The merge (`9c63d743d5cc`) didn't properly resolve the interaction — the new function's declaration exists in the `#ifdef CONFIG_DRM_FBDEV_EMULATION` block, but the corresponding `#else` stub was not added, so builds with `CONFIG_DRM_FBDEV_EMULATION=n` fail.
The fix is correct and straightforward. This is a standard linux-next fixup patch.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-13 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 9:56 [PATCH] [linux-next mismerge] drm/fbdev-emulation: restore drm_fb_helper_gem_is_fb() dummy Arnd Bergmann
2026-03-13 21:12 ` Claude review: " Claude Code Review Bot
2026-03-13 21:12 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260313095657.4115599-1-arnd@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox