public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/shmem-helper: Fix Map huge page mapping in fault handler
Date: Sat, 14 Mar 2026 06:52:13 +1000	[thread overview]
Message-ID: <review-overall-20260313141719.3949700-1-pedrodemargomes@gmail.com> (raw)
In-Reply-To: <20260313141719.3949700-1-pedrodemargomes@gmail.com>

Overall Series Review

Subject: drm/shmem-helper: Fix Map huge page mapping in fault handler
Author: Pedro Demarchi Gomes <pedrodemargomes@gmail.com>
Patches: 2
Reviewed: 2026-03-14T06:52:13.837152

---

This is a single-patch fix for a real race condition in `drm_gem_shmem_helper.c`. The bug occurs when two concurrent page faults within the same PMD range cause one fault to install a PMD mapping via `vmf_insert_pfn_pmd()` from the `.fault` handler, while another tries to install a PTE mapping via `vmf_insert_pfn()`. The kernel then hits a `BUG()` in `walk_to_pmd()` because it encounters an unexpected `pmd_trans_huge` entry.

The fix correctly separates the PMD mapping path into a `.huge_fault` callback, letting the mm subsystem properly route faults of different orders. The approach follows the same pattern already used by the VFIO PCI drivers (`vfio_pci_core.c`, `nvgrace-gpu/main.c`). The fix is appropriate and the Fixes tag is correct.

There are a couple of minor issues worth noting.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-03-13 20:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13 14:17 [PATCH v2] drm/shmem-helper: Fix Map huge page mapping in fault handler Pedro Demarchi Gomes
2026-03-13 17:08 ` Boris Brezillon
2026-03-13 20:52 ` Claude Code Review Bot [this message]
2026-03-13 20:52 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-16  0:26 [PATCH v3] " Pedro Demarchi Gomes
2026-03-16  1:46 ` Claude review: " Claude Code Review Bot
2026-03-16  1:46 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260313141719.3949700-1-pedrodemargomes@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox