From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Fix use-after-free on framebuffers and property blobs when calling drm_dev_unplug
Date: Sat, 14 Mar 2026 06:45:34 +1000 [thread overview]
Message-ID: <review-overall-20260313151728.14990-3-dev@lankhorst.se> (raw)
In-Reply-To: <20260313151728.14990-3-dev@lankhorst.se>
Overall Series Review
Subject: Fix use-after-free on framebuffers and property blobs when calling drm_dev_unplug
Author: Maarten Lankhorst <dev@lankhorst.se>
Patches: 2
Reviewed: 2026-03-14T06:45:34.233027
---
This single-patch series addresses a real use-after-free bug that occurs during `drm_dev_unplug` (hot-unplug / module reload) when userspace clients still have open file descriptors. The race is: the device gets torn down via `drm_mode_config_cleanup()` which frees framebuffers and blobs, but then userspace closes its fd and `drm_file_free()` tries to walk the now-freed `filp_head`/`head_file` lists — resulting in the oopses shown in the commit message.
The approach has the right idea — skip the fb/blob cleanup in `drm_file_free` when the device is already unplugged — but there are several concerns with the implementation.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-13 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 15:17 [PATCH v2 0/1] Fix use-after-free on framebuffers and property blobs when calling drm_dev_unplug Maarten Lankhorst
2026-03-13 15:17 ` [PATCH v2 1/1] drm: " Maarten Lankhorst
2026-03-13 20:45 ` Claude review: " Claude Code Review Bot
2026-03-13 20:45 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-02-25 10:15 [PATCH 0/1] " Maarten Lankhorst
2026-02-27 3:40 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260313151728.14990-3-dev@lankhorst.se \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox