Claude review: accel/amdxdna: Support retrieving hardware context debug information

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: accel/amdxdna: Support retrieving hardware context debug information
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 3
Reviewed: 2026-03-14T06:42:17.931971

---

This is a single patch adding support for retrieving hardware context health/debug information from the AIE2 firmware in the amdxdna accelerator driver. When a command times out, the driver queries the firmware for diagnostic information (GET_APP_HEALTH) and makes it available both via kernel log messages and through the hardware context query IOCTL to userspace.

The patch is generally well-structured and follows existing driver patterns. However, there are several issues that should be addressed, ranging from a potential stack overflow to a missing cache invalidation and some behavioral concerns.

**Key concerns:**
1. Large stack allocation (~560 bytes) in an IOCTL callback path
2. Missing DMA sync/cache invalidation after device write
3. Firmware query in a per-context iteration loop could cause latency issues under `dev_lock`
4. Minor: passing non-zero size with potentially NULL data pointer

---
Generated by Claude Code Patch Reviewer