From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: display-connector: detect DP state if cable is plugged on boot
Date: Mon, 16 Mar 2026 12:14:39 +1000 [thread overview]
Message-ID: <review-overall-20260314-dp-connector-hpd-v1-0-786044cedc17@oss.qualcomm.com> (raw)
In-Reply-To: <20260314-dp-connector-hpd-v1-0-786044cedc17@oss.qualcomm.com>
Overall Series Review
Subject: drm/bridge: display-connector: detect DP state if cable is plugged on boot
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 3
Reviewed: 2026-03-16T12:14:39.415482
---
This is a clean, well-motivated 2-patch series from Dmitry Baryshkov fixing a real boot-time HPD detection issue for DisplayPort connectors using the `display-connector` bridge driver. If a DP cable is plugged in before the system boots, there's no rising/falling edge on the HPD GPIO, so no IRQ fires and the DP controller never learns about the connection. The fix is straightforward: (1) defer IRQ enabling to the `hpd_enable` callback, and (2) synthesize an initial HPD notification for DP connectors when HPD is enabled.
The approach is sound and the patches are correctly ordered. I have a few observations below.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-16 2:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 0:43 [PATCH 0/2] drm/bridge: display-connector: detect DP state if cable is plugged on boot Dmitry Baryshkov
2026-03-14 0:43 ` [PATCH 1/2] drm/bridge: display-connector: don't autoenable HPD IRQ Dmitry Baryshkov
2026-03-16 2:14 ` Claude review: " Claude Code Review Bot
2026-03-14 0:43 ` [PATCH 2/2] drm/bridge: display-connector: trigger initial HPD event for DP Dmitry Baryshkov
2026-03-16 2:14 ` Claude review: " Claude Code Review Bot
2026-03-16 2:14 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260314-dp-connector-hpd-v1-0-786044cedc17@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox