From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: display-connector: detect DP state if cable is plugged on boot Date: Mon, 16 Mar 2026 12:14:39 +1000 Message-ID: In-Reply-To: <20260314-dp-connector-hpd-v1-0-786044cedc17@oss.qualcomm.com> References: <20260314-dp-connector-hpd-v1-0-786044cedc17@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: display-connector: detect DP state if cable is plugged on boot Author: Dmitry Baryshkov Patches: 3 Reviewed: 2026-03-16T12:14:39.415482 --- This is a clean, well-motivated 2-patch series from Dmitry Baryshkov fixing a real boot-time HPD detection issue for DisplayPort connectors using the `display-connector` bridge driver. If a DP cable is plugged in before the system boots, there's no rising/falling edge on the HPD GPIO, so no IRQ fires and the DP controller never learns about the connection. The fix is straightforward: (1) defer IRQ enabling to the `hpd_enable` callback, and (2) synthesize an initial HPD notification for DP connectors when HPD is enabled. The approach is sound and the patches are correctly ordered. I have a few observations below. --- Generated by Claude Code Patch Reviewer